Calendar picker. #10 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually merged
Bluebugs
requested changes
Jun 1, 2022
location.go
Outdated
| } | ||
|
|
||
| func calendar(l *location) { | ||
| l.calendar = container.New(NewCalendarLayout(32), calendarObjects(l)...) |
There was a problem hiding this comment.
Would it be possible to move all the function and logic related to the Calendar to its own file? I would also expect a l.calendar := newCalendar().
location.go
Outdated
| b := container.New(layout.NewBorderLayout(nil, nil, l.monthPrevious, l.monthNext), | ||
| l.monthPrevious, l.monthNext, container.NewCenter(l.monthLabel)) | ||
|
|
||
| l.dateContainer = container.NewVBox(b, l.calendar) |
There was a problem hiding this comment.
Maybe also an newCalendarPopup() with showAtPosition function.
location.go
Outdated
| monthNext *widget.Button | ||
|
|
||
| dateContainer *fyne.Container | ||
| calendar *fyne.Container |
There was a problem hiding this comment.
Not sure that you actually need to store this here.
I initially tried to use |
This will matter when the text changes
Bluebugs
reviewed
Jun 2, 2022
Bluebugs
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deviations from design:
Small inset of date button due to button padding
Colours
Calendar popup position is the same regardless of scroll position or button clicked, to be changed?
No dropdown arrow icon next to date button