Simplify the code #12
Conversation
| return Generator(columns, column_access, _generator) | ||
|
|
||
|
|
||
| def coerce_section_name(name: str | None) -> str | None: |
There was a problem hiding this comment.
what's the difference between "undefined" and None?
There was a problem hiding this comment.
TODO: add better explanation
| # TODO(fzakaria): Better understand why is it auxiliary? | ||
| # this returns versions like GLIBC_2.2.5 | ||
| "version": symbol.symbol_version.symbol_version_auxiliary.name | ||
| if symbol.symbol_version |
There was a problem hiding this comment.
move this to an if else expression on its own line above
| for binary in binaries: | ||
| # super important that these accessors are pulled out of the tight loop | ||
| # as they can be costly | ||
| binary_name = binary.name |
There was a problem hiding this comment.
why this assignment? why not do binary.name below, like for section.name?
There was a problem hiding this comment.
the comment says its in a tight loop for each section so I'm avoiding needless back and forth between the c-code when possible.
I thought I found it to affect the performance --
Consider the case of instructions that can have 700k row.
That's saving at least 1 boundary....
| class Generator: | ||
| """A generator for the virtual table SQLite module.""" | ||
|
|
||
| columns: Sequence[str] |
There was a problem hiding this comment.
where do you use these attributes?
There was a problem hiding this comment.
apsw uses them for figuring out how to create the virtual table accessor.
| column_access: apsw.ext.VTColumnAccess | ||
| callable: Callable[[], Iterator[dict[str, Any]]] | ||
|
|
||
| def __call__(self) -> Iterator[dict[str, Any]]: |
There was a problem hiding this comment.
implementing __call__ is a little weird unless it's an API that apsw expects - and then, why not pass the generator where you need it?
There was a problem hiding this comment.
mypy or pyright (can't remember) were giving me typing issues.
The problem is that it just expects a generator but it wants to assign the properties column_access and columns on it.
Looks like the "way to do it" in python is to create a wrapper class basically I think.
Maybe I can use Protocols?
No description provided.