Make the tables that are registered configurable #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the list of tables configurable in the API. Some of the tables are quite expensive to generate such a instructions or symbols. Allow the users to configure which tables to generate when they create a sql_engine.
fzakaria
commented
Sep 26, 2023
Comment on lines
+39
to
+59
| class GeneratorFlag(Flag): | ||
| NONE = 0 | ||
| DYNAMIC_ENTRIES = auto() | ||
| HEADERS = auto() | ||
| INSTRUCTIONS = auto() | ||
| SECTIONS = auto() | ||
| SYMBOLS = auto() | ||
| STRINGS = auto() | ||
| VERSION_REQUIREMENTS = auto() | ||
| VERSION_DEFINITIONS = auto() | ||
|
|
||
| @classmethod | ||
| def ALL(cls: type[GeneratorFlag]) -> GeneratorFlag: | ||
| retval = cls.NONE | ||
| for member in cls.__members__.values(): | ||
| retval |= member | ||
| return retval | ||
|
|
||
|
|
||
| @dataclass | ||
| class MakeGeneratorResponse: |
There was a problem hiding this comment.
@markrwilliams maybe you have ideas how to make this nicer.
Kind of hate my naming and how this all gets constructed....
at least it's data class /shrug
fzakaria
commented
Sep 26, 2023
Comment on lines
+7
to
+31
| @pytest.mark.slow | ||
| def test_symbol_resolutions() -> None: | ||
| # TODO(fzakaria): Make sure this binary | ||
| # is always present in the CI environment. | ||
| sql_engine = sql.make_sql_engine( | ||
| ["/usr/bin/ruby"], recursive=True, flags=elf.GeneratorFlag.SYMBOLS | ||
| ) | ||
| result = sql_engine.execute( | ||
| """ | ||
| SELECT caller.path as 'caller.path', | ||
| callee.path as 'calee.path', | ||
| caller.name, | ||
| caller.demangled_name | ||
| FROM ELF_SYMBOLS caller | ||
| INNER JOIN ELF_SYMBOLS callee | ||
| ON | ||
| caller.name = callee.name AND | ||
| caller.path != callee.path AND | ||
| caller.imported = TRUE AND | ||
| callee.exported = TRUE | ||
| LIMIT 25 | ||
| """ | ||
| ) | ||
| rows = list(result) | ||
| assert len(rows) == 25 |
There was a problem hiding this comment.
This method even with only the symbols takes ~4 seconds..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the list of tables configurable in the API.
Some of the tables are quite expensive to generate such a instructions or symbols.
Allow the users to configure which tables to generate when they create a sql_engine.
CC @markrwilliams