This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Added Malaysia Localized data and fix Singapore able to generate StreetName from Array #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiroamada
changed the title
fzaninotto
suggested changes
Jul 3, 2017
| 'Jalan', 'Lorong', | ||
| ); | ||
|
|
||
| // http://www.streetdirectory.com/malaysia/kl/asia_travel/street/ |
There was a problem hiding this comment.
The content of this site is copyrighted. Please find a datasource compatible with the MIT license.
| "{{streetNumber}} {{streetAddress}},\n{{postcode}} {{townName}},\n{{country}}", | ||
| ); | ||
|
|
||
| protected static $townName = array( |
There was a problem hiding this comment.
Not enough entropy, please find a larger list
| protected static $postcode = array('#####'); | ||
|
|
||
| protected static $country = array( | ||
| 'Malaysia', |
There was a problem hiding this comment.
No, a random country should return any country in the world
| 'Malaysia', | ||
| ); | ||
|
|
||
| public function streetPrefix() |
There was a problem hiding this comment.
should be a static function. Same for many other functions in your code.
|
Closing this PR since it got stale. Please feel free to reopen if needed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Malaysia Localized data