Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Replace LoremPixel with Unsplash #1547

Closed
wants to merge 2 commits into from
Closed

Replace LoremPixel with Unsplash #1547

wants to merge 2 commits into from

Conversation

elwin
Copy link

@elwin elwin commented Aug 12, 2018

LoremPixel is down once again, so I thought I'd try to replace it with Unsplash Source.

This would however add breaking changes:

  • No categories (instead they use search keywords)
  • No grayscale
  • No text overlay
  • Images are always random

Therefore the method signature would change from

public static function imageUrl($width = 640, $height = 480, $category = null, $randomize = true, $word = null, $gray = false)

to

public static function imageUrl($width = 640, $height = 480, $keywords = null)

For the image method accordingly.


You mentioned you would rather drop image support all together, however, for me and probably many other developers, image generation is a valuable part of the package.

Please let me know if you're not interested or if there's something horribly wrong with the PR (it's my first PR, so I'd be glad for feedback!).

@fzaninotto
Copy link
Owner

I've already said that I won't accept such PRs. I want to remove the image generator, not to add more. See #957 for the rationale.

@fzaninotto fzaninotto closed this Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants