Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Enhancement: Run builds on master using GitHub Actions #1954

Merged
merged 1 commit into from Mar 12, 2020

Conversation

localheinz
Copy link
Contributor

This PR

  • runs builds on master using GitHub Actions

馃拋鈥嶁檪 With https://github.com/shivammathur/setup-php/releases/tag/2.0.0 we have support for running PHP 5.3, PHP 5.4, and PHP 5.5 on GitHub Actions.

@localheinz localheinz added this to the 1.9.2 milestone Mar 11, 2020
@localheinz localheinz self-assigned this Mar 11, 2020
@localheinz localheinz force-pushed the feature/github-actions branch 3 times, most recently from a73910d to b94bdfd Compare March 11, 2020 15:06
@localheinz localheinz marked this pull request as ready for review March 11, 2020 15:07
@localheinz localheinz assigned pimjansen and unassigned localheinz Mar 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #1954 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1954      +/-   ##
============================================
+ Coverage     56.58%   56.68%   +0.10%     
  Complexity     2068     2068              
============================================
  Files           306      306              
  Lines          4851     4851              
============================================
+ Hits           2745     2750       +5     
+ Misses         2106     2101       -5     
Impacted Files Coverage 螖 Complexity 螖
src/Faker/Calculator/TCNo.php 93.33% <酶> (酶) 5.00 <0.00> (酶)
src/Faker/Provider/en_IN/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (酶%)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (酶%)
src/Faker/Provider/es_VE/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (酶%)
src/Faker/Provider/sr_Latn_RS/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (酶%)
src/Faker/Provider/fa_IR/Address.php 73.33% <0.00%> (-26.67%) 7.00% <0.00%> (酶%)
src/Faker/Provider/es_PE/Address.php 75.00% <0.00%> (-25.00%) 4.00% <0.00%> (酶%)
src/Faker/Provider/sk_SK/Person.php 66.66% <0.00%> (-22.23%) 9.00% <0.00%> (酶%)
src/Faker/Provider/hu_HU/Person.php 60.00% <0.00%> (-20.00%) 5.00% <0.00%> (酶%)
src/Faker/Provider/vi_VN/Person.php 40.00% <0.00%> (-20.00%) 5.00% <0.00%> (酶%)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3201746...d8104c1. Read the comment docs.

@pimjansen
Copy link
Contributor

@localheinz i see it is still waiting for a travis build is that correct? Or can that be ignored

@localheinz
Copy link
Contributor Author

@pimjansen

I think that needs to be removed from the branch protection settings.

@fzaninotto

Can you take a look, please?

@fzaninotto fzaninotto merged commit 468dfa6 into fzaninotto:master Mar 12, 2020
@fzaninotto
Copy link
Owner

Thanks!

@localheinz localheinz deleted the feature/github-actions branch March 12, 2020 15:22
@localheinz
Copy link
Contributor Author

Thank you, @fzaninotto and @pimjansen!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants