Inn mask #1986
Inn mask #1986
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1986 +/- ##
============================================
+ Coverage 70.21% 70.55% +0.34%
- Complexity 1600 1610 +10
============================================
Files 287 287
Lines 3864 3885 +21
============================================
+ Hits 2713 2741 +28
+ Misses 1151 1144 -7
Continue to review full report at Codecov.
|
src/Faker/Provider/ru_RU/Company.php
Outdated
| @@ -96,7 +96,7 @@ public static function companyNameSuffix() | |||
| return static::randomElement(static::$companyNameSuffixes); | |||
| } | |||
|
|
|||
| public static function inn($area_code = "") | |||
| public static function inn($area_code = "", $mask = '#######') | |||
There was a problem hiding this comment.
Use mask as parameter is not good idea. I think better is use type of INN: for Person (12 digits) or Company (10 digits)
And then use type inside method for generate mask.
There was a problem hiding this comment.
Or move INN generator to common function in \Faker\Calculator\Inn and add inn to Person.php too
There was a problem hiding this comment.
Or move INN generator to common function in \Faker\Calculator\Inn and add inn to Person.php too
Thank you for your comments. Using Inn base class and divide the INN for the company and person will be more object-oriented way.
src/Faker/Calculator/Inn.php
Outdated
| @@ -15,8 +15,11 @@ class Inn | |||
| public static function checksum($inn) | |||
There was a problem hiding this comment.
There is possible add INN type (Person or Company) and then use it in cases inside method
Now you can use 12 digits of the Inn.