This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
[refactor] complies with psr-2 #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
============================================
- Coverage 56.56% 56.36% -0.21%
Complexity 2068 2068
============================================
Files 306 306
Lines 4849 4849
============================================
- Hits 2743 2733 -10
- Misses 2106 2116 +10
Continue to review full report at Codecov.
|
pimjansen
approved these changes
Oct 23, 2020
|
Thanks |
GrahamCampbell
pushed a commit
to FakerPHP/Faker
that referenced
this pull request
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored some methods which were not psr-2 compliant.
Please review.