Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Enhancement: Raise error level from 5 to 4 #2084

Closed
wants to merge 4 commits into from

Conversation

localheinz
Copy link
Contributor

This PR

  • raises the error level for vimeo/psalm from 5 to 4
  • fixes issues reported via static code analysis

Follows #1897.

@localheinz localheinz added this to the 2.0.0 milestone Oct 23, 2020
@localheinz localheinz self-assigned this Oct 23, 2020
@localheinz localheinz added this to In progress in Faker 2.0 via automation Oct 23, 2020
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #2084 into next will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               next    #2084      +/-   ##
============================================
+ Coverage     70.82%   70.95%   +0.12%     
  Complexity     1599     1599              
============================================
  Files           287      287              
  Lines          3863     3863              
============================================
+ Hits           2736     2741       +5     
+ Misses         1127     1122       -5     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/ms_MY/Address.php 94.33% <ø> (+3.77%) 13.00 <0.00> (ø)
src/Faker/Provider/ms_MY/Miscellaneous.php 0.00% <ø> (ø) 7.00 <0.00> (ø)
src/Faker/Provider/ms_MY/Payment.php 0.00% <ø> (ø) 8.00 <0.00> (ø)
src/Faker/Provider/de_AT/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/es_AR/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/sv_SE/Address.php 50.00% <0.00%> (-50.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/en_AU/PhoneNumber.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/ro_MD/Address.php 65.21% <0.00%> (-34.79%) 10.00% <0.00%> (ø%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ea784...1dd9c78. Read the comment docs.

@localheinz localheinz closed this Oct 23, 2020
Faker 2.0 automation moved this from In progress to Done Oct 23, 2020
@localheinz localheinz deleted the feature/error-level-4 branch October 23, 2020 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Faker 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants