Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Enhancement: Enable UnusedUses rule #2086

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Enhancement: Enable UnusedUses rule #2086

merged 2 commits into from
Oct 23, 2020

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Oct 23, 2020 •
edited
Loading

This PR

  • enables the SlevomatCodingStandard.Namespaces.UnusedUses rule
  • runs make fix

Follows #1896.

@localheinz localheinz added this to the 2.0.0 milestone Oct 23, 2020
@localheinz localheinz self-assigned this Oct 23, 2020
@localheinz localheinz added this to In progress in Faker 2.0 via automation Oct 23, 2020
@localheinz localheinz assigned fzaninotto and pimjansen and unassigned localheinz Oct 23, 2020
@localheinz localheinz marked this pull request as ready for review October 23, 2020 13:57
@pimjansen pimjansen merged commit 9104770 into fzaninotto:next Oct 23, 2020
Faker 2.0 automation moved this from In progress to Done Oct 23, 2020
@localheinz localheinz deleted the feature/unused-uses branch October 23, 2020 16:01
@localheinz
Copy link
Contributor Author

Thank you, @pimjansen!

@fzaninotto
Copy link
Owner

Guys, these project tooling PRs bring zero value to the end users. If you have some spare time to work on Faker, please spend it fixing one of the 173 open issues. I know it's not as fun, but it's the most part of what being an open-source maintainer means.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pimjansen pimjansen pimjansen approved these changes

@fzaninotto fzaninotto Awaiting requested review from fzaninotto

Assignees

@fzaninotto fzaninotto

@pimjansen pimjansen

Labels
enhancement
Projects
Faker 2.0
  
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@localheinz @fzaninotto @pimjansen