This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Add jobTitle generator #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,10 @@ class Company extends \Faker\Provider\Base | |||
| '{{lastName}} {{companySuffix}}', | |||
| ); | |||
|
|
|||
| protected static $jobTitle = array( | |||
| 'Account Executive', 'Account Manager', 'Accountant', 'Administrative Assistant', 'Assistant Manager', 'Assistant Store Manager', 'Business Analyst', 'Cashier', 'Cook', 'Customer Sales Representative', 'Customer Service', 'Driver', 'Engineer', 'Executive Assistant', 'Financial Analyst', 'Java Developer', 'Maintenance Technician', 'Manager', 'Merchandiser', 'Nurse', 'Occupational Therapist', 'Occupational Therapy Assistant', 'Pharmacist', 'Physcial Therapist', 'Program Manager', 'Project Manager', 'Receptionist', 'Registered Nurse', 'Restaurant Manager', 'Retail Sales Consultant', 'Sales', 'Sales Associate', 'Sales Manager', 'Sales Representative', 'Security Officer', 'Senior Accountant', 'Software Engineer', 'Speech Language Therapist', 'Store Manager', 'Systems Engineer', 'Technician', 'Teller', | |||
There was a problem hiding this comment.
I think this list should be in the en_US locale. For the no-locale formatter, you should rely on the lorem words.
Also, could you please split the line by first letter, to improve code readability?
|
@fzaninotto hopefully have implemented your comments correctly. |
| /* | ||
| * @example 'Cashier' | ||
| */ | ||
| public static function jobTitle() |
There was a problem hiding this comment.
Can't be static, because of $this. A unit tests would have showed it to you. This shows me that you haven't tested you own code, it's bad. Please add a unit test.
|
Hopefully, fingers crossed, I'm there now. |
|
Still missing a unit test |
|
Added the unit test now. |
|
Status on this pull? |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #626