-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sometimes see Lost connection to device.
in worker, when hot restarting it, related to Flutter's UIViewAnimationBlockDelegate
#188
Comments
[TODO] firstly, examine whether there is a crash log [TODO] maybe the isolate we send hotRestart to is wrong? |
https://stackoverflow.com/questions/1864479/crash-logs-generated-by-iphone-simulator (base) ➜ ~ ls ~/Library/Logs/DiagnosticReports/ |
|
last night crash
|
last morning crash
|
seems to have common cause:
|
wait until we upgrade to flutter 3.0. maybe it is fixed later? |
see again today. Logs
|
have a look at |
Is it possible because: we hot-restart, before splash screen finishes?just a guess. If so, can we avoid it? [TODO] |
Lost connection to device.
in worker, when hot restarting it, related to Flutter's UIViewAnimationBlockDelegate
after all the code fixes, it still crashes sometimes.
|
Another guess Is it because, when the worker is started and hot-restarted, it has not pump any frames? Experiment: close everything - run worker - run manager - click "connect" and then "run all" in manager -> No crash this time... (since randomly) Maybe this guess is also wrong |
given that flutter/flutter#37818 is fixed by flutter/engine#34496, we will not face this problem after next (or next-next) flutter release once that PR is in stable branch. |
A similar crash happened to me.
|
Good to know that this is not only seen by me. Anyway, flutter seems to have fixed the issue, and I have reported your report there as well just now |
Ah, that's cool! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump until confirmed |
Just to say that I'm experiencing this issue in CI even with the latest flutter master. (GitHub actions, ubuntu-lates, Android emulator) Currently doing some testing to see how often it loses connection, and if there's any benefit to using macos/windows. If it is very regular I would be in favour of a flutter test version (even if some features are lost). Although got web support to look at first. |
@rob-mur That is a bug of Flutter (not this repo), could you please file a bug there if you still see it? |
Yep of course, not saying it's your fault at all. I will do if I can get enough consistent log reports - it's not very consistent! |
@rob-mur Take your time :) Maybe link to this issue as well in that bug report so I will know it (and flutter team will know some more context) |
For now I think my two options are to either just use integration test for CI until they fix this, or to create a stripped down version of this tool for CI which doesn't need the manager/hot restarting. I'm leaning towards the former for now in the hopes they just fix the issue to avoid rewriting your tool! |
I am also looking forward to they fixing this! |
Hey, they've asked for a minimal repro that doesn't use your tester. Could you please point me towards how you got restart a running app? (Otherwise I can look it up but it would save me some time!) |
Line 98 in 9184981
|
Thanks, I'll take a look when I can. I've also tried recently moving to a hardware accelerated enabled (gpu passthrough + kvm enabled) self hosted Linux container and this seems to have reduced the incidence of the error. Will keep you posted. |
Btw I also reproduced yesterday. following is the error message. the error is a little bit different from the one a few month ago indeed - now it is an exception
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue. |
No description provided.
The text was updated successfully, but these errors were encountered: