Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DelegatingFinder for flutter 3.16.2 #355

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

madmini
Copy link
Contributor

@madmini madmini commented Dec 5, 2023

When building convenient_test_manager for Windows on master I get the following error message:

> flutter build windows

../convenient_test_dev/lib/src/utils/util.dart(6,7): error G76B49859: The non-abstract class 'DelegatingFinder' is missing implementations for these members: [...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\flutter\flutter_assemble.vcxproj]
../convenient_test_dev/lib/src/utils/util.dart(25,21): error G0A556F40: The return type of the method 'DelegatingFinder.evaluate' is 'Iterable<Element>', which does not match the return type, 'FinderResult<Element>', of the overridden method, 'FinderBase.evaluate'. [...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\flutter\flutter_assemble.vcxproj]
../convenient_test_dev/lib/src/utils/util.dart(43,10): error GE5CFE876: The method 'DelegatingFinder.toString' has fewer named arguments than those of overridden method 'FinderBase.toString'. [...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\flutter\flutter_assemble.vcxproj]
...\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for '...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\CMakeFiles\ded4cdf977ef776379c919ab64e04105\flutter_windows.dll.rule;...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\CMakeFiles\bcf9c5332835a00d3f9f7d34f711e896\flutter_assemble.rule' exited with code 1. [...\flutter_convenient_test\packages\convenient_test_manager\build\windows\x64\flutter\flutter_assemble.vcxproj]
Building Windows application...                                    22,4s
Build process failed.

Looking into DelegatingFinder some methods are incompatible with what I assume were changes introduced in flutter 3.13.0.

I have fixed and extended the class while trying to retain its purpose. With these changes, I am able to build and run the manager as expected, though I have not fully tested it.

Copy link

welcome bot commented Dec 5, 2023

Hi! Thanks for opening this pull request! 😄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Dec 5, 2023

LGTM, great job!

@fzyzcjy fzyzcjy merged commit 552bc7f into fzyzcjy:master Dec 5, 2023
5 of 9 checks passed
Copy link

welcome bot commented Dec 5, 2023

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Dec 5, 2023

@all-contributors please add @madmini for code

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @madmini! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants