Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Freezed file is sometimes not generated when it should be #330

Closed
Tracked by #327
SecondFlight opened this issue Feb 11, 2022 · 3 comments
Closed
Tracked by #327
Labels
bug Something isn't working

Comments

@SecondFlight
Copy link
Contributor

SecondFlight commented Feb 11, 2022

In hindsight, I probably should have tested #319 a bit more thoroughly 😅

I'm running codegen on a larger test project with enums, and flutter_rust_bridge is not generating a freezed file.

I'm early in investigating this, but I think this is happening because distinct_types() in api_types.rs doesn't know how to find imported types. I have no idea why this isn't causing more things to break, so it might be a red herring.

If all goes well I'll have a fix for this soon. @fzyzcjy This issue shouldn't cause any existing code to break, so it's up to you if you want to wait for the fix.

@SecondFlight SecondFlight changed the title [Bug] Freezed file is not generated if you only have enums in imported files [Bug] Freezed file is sometimes not generated when it should be Feb 11, 2022
@fzyzcjy
Copy link
Owner

fzyzcjy commented Feb 11, 2022

Hmm maybe I will wait for the fix. Since this bug is related to #319, and the next release is mainly about #319 as well. But don't worry, take your time!

@fzyzcjy fzyzcjy added the bug Something isn't working label Feb 11, 2022
@SecondFlight
Copy link
Contributor Author

Turns out, not running build_runner can cause issues 🤦‍♂️

I'm still seeing something, but it's unrelated to #319 as best I can tell. I'll open a separate bug for that momentarily.

@fzyzcjy fzyzcjy mentioned this issue Feb 11, 2022
10 tasks
fzyzcjy added a commit to Desdaemon/flutter_rust_bridge that referenced this issue Feb 12, 2022
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants