Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support renaming functions and methods #1958

Merged
merged 17 commits into from
May 19, 2024
Merged

Support renaming functions and methods #1958

merged 17 commits into from
May 19, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented May 19, 2024

Changes

Close #1924

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support function rename, thus support arbitrarily named functions like operator<= Support renaming functions and methods May 19, 2024
@fzyzcjy fzyzcjy marked this pull request as ready for review May 19, 2024 11:56
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (2f44920) to head (6a75d97).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1958   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         369      369           
  Lines       15808    15842   +34     
=======================================
+ Hits        15686    15720   +34     
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 5c10f66 into master May 19, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement operator overloading methods (for external opaque types)
1 participant