remove overhead analysis by Timeline event since timeline itself need…

…s time
fzyzcjy · Oct 16, 2022 · d9cc91f · d9cc91f
1 parent ee39efe
commit d9cc91f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 69 deletions.
diff --git a/packages/smooth/lib/src/actor.dart b/packages/smooth/lib/src/actor.dart
@@ -23,30 +23,28 @@ class Actor {
     final serviceLocator = ServiceLocator.instance;
     if (serviceLocator.auxiliaryTreeRegistry.trees.isEmpty) return;
 
-    Timeline.timeSync('MaybePreemptRender', () {
-      final timeManager = serviceLocator.timeManager;
-      final now = clock.nowSimple();
-      final nowTimestamp =
-          serviceLocator.timeConverter.dateTimeToAdjustedFrameTimeStamp(now);
-
-      if (timeManager.thresholdActOnBuildOrLayoutPhaseTimeStamp! >=
-          nowTimestamp) {
-        // _debugLogMaybePreemptRender(haltReason: 'TimeTooEarly');
-        return;
-      }
+    final timeManager = serviceLocator.timeManager;
+    final now = clock.nowSimple();
+    final nowTimestamp =
+        serviceLocator.timeConverter.dateTimeToAdjustedFrameTimeStamp(now);
+
+    if (timeManager.thresholdActOnBuildOrLayoutPhaseTimeStamp! >=
+        nowTimestamp) {
+      // _debugLogMaybePreemptRender(haltReason: 'TimeTooEarly');
+      return;
+    }
 
-      // this should be called *after* time check, since this may be a bit more
-      // expensive
-      if (!_preludeBeforePreemptRender()) {
-        // _debugLogMaybePreemptRender(haltReason: 'PreludeDisagree');
-        return;
-      }
+    // this should be called *after* time check, since this may be a bit more
+    // expensive
+    if (!_preludeBeforePreemptRender()) {
+      // _debugLogMaybePreemptRender(haltReason: 'PreludeDisagree');
+      return;
+    }
 
-      _preemptRenderRaw(
-          debugReason: RunPipelineReason.preemptRenderBuildOrLayoutPhase);
+    _preemptRenderRaw(
+        debugReason: RunPipelineReason.preemptRenderBuildOrLayoutPhase);
 
-      timeManager.afterBuildOrLayoutPhasePreemptRender(now: nowTimestamp);
-    });
+    timeManager.afterBuildOrLayoutPhasePreemptRender(now: nowTimestamp);
   }
 
   void maybePreemptRenderPostDrawFramePhase() {

diff --git a/scripts/timeline/overhead.py b/scripts/timeline/overhead.py