Merge pull request #2 from g--o/fix/dirname-undefined

#1 fixing deprecated undefined handling of path.dirname
g--o · Apr 21, 2021 · f50e934 · f50e934
2 parents 0d0a89b + 271f1e4
commit f50e934
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/minify-j-s.js b/lib/minify-j-s.js
@@ -173,12 +173,19 @@ export default {
     load_paths(isDir, isOut) {
         path = require("path");
         editor = atom.workspace.getActiveTextEditor();
+        var filePath = "";
 
         // get file path from editor
         if (!editor)
             filePath = DEFAULT_OUT_PATH;
         else
             filePath = editor.getPath();
+
+        if (!filePath) {
+            alert("Somehow couldn't determine a path, please select a file and try again");
+            return;
+        }
+
         fileDir = path.dirname(filePath);
 
         // auto complete current dir and build path.