Fixed remove underlying pixels feature (cvat-ai#7637)

g-kartik · Mar 29, 2024 · 2c2fd19 · 2c2fd19
1 parent d2cc8de
commit 2c2fd19
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/changelog.d/20240319_142812_klakhov_fix_remove_underlying_pixels.md b/changelog.d/20240319_142812_klakhov_fix_remove_underlying_pixels.md
@@ -0,0 +1,4 @@
+### Fixed
+
+- Remove underlying pixels feature is not applied immediately
+  (<https://github.com/opencv/cvat/pull/7637>)
diff --git a/cvat-ui/package.json b/cvat-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cvat-ui",
-  "version": "1.63.2",
+  "version": "1.63.3",
   "description": "CVAT single-page application",
   "main": "src/index.tsx",
   "scripts": {

diff --git a/cvat-ui/src/components/annotation-page/canvas/views/canvas2d/brush-tools.tsx b/cvat-ui/src/components/annotation-page/canvas/views/canvas2d/brush-tools.tsx
@@ -83,7 +83,6 @@ function BrushTools(): React.ReactPortal | null {
 
     useEffect(() => {
         const label = labels.find((_label: any) => _label.id === defaultLabelID);
-        getCore().config.removeUnderlyingMaskPixels.enabled = removeUnderlyingPixels;
         if (visible && label && canvasInstance instanceof Canvas) {
             const onUpdateConfiguration = ({ brushTool }: any): void => {
                 if (brushTool?.size) {
@@ -122,6 +121,10 @@ function BrushTools(): React.ReactPortal | null {
         }
     }, [currentTool, brushSize, brushForm, visible, defaultLabelID, editableState]);
 
+    useEffect(() => {
+        getCore().config.removeUnderlyingMaskPixels.enabled = removeUnderlyingPixels;
+    }, [removeUnderlyingPixels]);
+
     useEffect(() => {
         setApplicableLabels(filterApplicableForType(LabelType.MASK, labels));
     }, [labels]);