Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped Webpack for ts compiler #64

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Shenato
Copy link
Contributor

@Shenato Shenato commented Oct 27, 2023

This should help with the Nextjs window issues since you wont have to import code that references window useWindowSize isn't imported

@Shenato
Copy link
Contributor Author

Shenato commented Oct 29, 2023

Note: This PR Updates the eslint rulings and tries to enforce a stricter typescript coding standard, a separate PR should be opened after to fix all the issues caught by the new linter

@UTkzhang
Copy link

This is great @Shenato, please let me know how we can support to get this merged and released

@Shenato
Copy link
Contributor Author

Shenato commented Nov 28, 2023

I've been trying to make a manual beta release for testing to make sure it works before doing a full release and merging it to main, but I was just made aware that I don't actually have access to the npm package itself. So manually releasing isn't possible for me right now. I'm trying to get it sorted as we're speaking.

For now if you @UTkzhang or anyone else who's interested in helping me test and verify that this branch fixes #56, #34 as well any other Nextjs compatibility tickets that I might've missed, please feel free to do so in the meantime until i fix my npm access issues. I have some suggestions on how you could do so below

Suggested method of testing

You could clone this branch, build it locally and npm pack the dist folder then install it in your NextJS project using one of those two ways:

Otherwise If you manage to find better instructions how to use those two methods OR you have a better suggestion for how to package and test this branch please do so and let me know how you managed.

This was linked to issues Nov 28, 2023
@Shenato Shenato added the help wanted Extra attention is needed label Nov 28, 2023
@Shenato
Copy link
Contributor Author

Shenato commented Dec 3, 2023

Update: I've finally managed to publish a release candidate right here on npm
https://www.npmjs.com/package/@g-loot/react-tournament-brackets/v/1.0.31-rc

Please use this version, test it out and let me know if it works with nextjs, regular client-side react and see if it solves #56 and #34
on those two environments.

@feldrok
Copy link

feldrok commented Dec 20, 2023

It's working for me on Next.js, but have type errors on

matchComponent={Match}
Unsafe assignment of an any value.

and

svgWrapper={({ children, ...props }) => ( <SVGViewer width={500} height={500} {...props}> {children} </SVGViewer> )}
Binding element 'children' implicitly has an 'any' type.

@Shenato
Copy link
Contributor Author

Shenato commented Dec 22, 2023

Latest update, I just lost access to this repository, since this package is under Stryda's namespace, they just recently had issues at the company and had to remove outside collaborators (including my account) from the organization on Github.

So I will be attempting to make a fork of this repository, npm package and github package under my own account soon.

@Shenato
Copy link
Contributor Author

Shenato commented Dec 23, 2023

as I said before, I lost write access to this repository, so I've mirrored it in my own repository.

The PR is continued here Shenato/react-tournament-brackets#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextJS e.find is not a function NextJs Compatibility?
3 participants