Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

code refactoring, removing logs, change xpath of total-pages element, converts rgba modes to rgb #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohrfacu
Copy link

@rohrfacu rohrfacu commented Jan 5, 2019

No description provided.

@bySabi
Copy link

bySabi commented Jan 6, 2019

@rohrfacu I tested it and works really fine.
I'm wondering if we can remove the scribd bar with page numbers and Search part

@rohrfacu
Copy link
Author

rohrfacu commented Jan 7, 2019

@rohrfacu I tested it and works really fine.
I'm wondering if we can remove the scribd bar with page numbers and Search part

It can be done, i need to figure out how to take a screenshot of a specific element, i'll submit a new PR when i make this!

@rohrfacu
Copy link
Author

rohrfacu commented Jan 7, 2019

@rohrfacu I tested it and works really fine.
I'm wondering if we can remove the scribd bar with page numbers and Search part

Ready, check the last PR, i removed the fullscreen mode, in this mode, the element that we took screenshots from included the pages and searchbar in it, so i just commented this part.

@bySabi
Copy link

bySabi commented Jan 7, 2019

Tested. You did it!!
It works really well. The best script that works at this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants