Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for perspective(...) is wrong in 0.9.6.3 #327

Closed
Ident opened this issue Apr 2, 2015 · 1 comment
Closed

Documentation for perspective(...) is wrong in 0.9.6.3 #327

Ident opened this issue Apr 2, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@Ident
Copy link

Ident commented Apr 2, 2015

it says:
"fovy Specifies the field of view angle, in degrees, in the y direction. Expressed in radians. "
it should probably be:
"fovy Specifies the field of view angle in the y direction. Expressed in radians. "

This change of the function btw. broke the rendering of our library (CEGUI) for versions >= 0.9.6, but we were able to fix this easily using a macro based on the glm version numbers - once we figured out what was the cause. Nevertheless, we are very very glad that now radians are used by default always here and in other places, the previously available option to choose between degrees and radians was potentially very problematic for users who might have used glm as well in their application and defined it differently than we would expect (changing it from the default).

@Groovounet Groovounet added the bug label May 1, 2015
@Groovounet Groovounet added this to the GLM 0.9.7 milestone May 1, 2015
@Groovounet Groovounet self-assigned this May 1, 2015
@Groovounet
Copy link
Member

This issue is fixed in master branch for GLM 0.9.7.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants