GLM_ENABLE_EXPERIMENTAL option / install cleanup #741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm auto-builds failed and I can't find links to results anymore... |
It seems that erroring out if GLM_ENABLE_EXPERIMENTAL is not set turns into packagers nightmare: There are packages around expecting glx headers. E.g libgltf [1] fails during configure checking for usable headers AND during compile. Paticularly fixing configure for those packages is time-consuming: The only way (correct me if I am wrong) is creating a patch adding AC_DEFINE([GLM_ENABLE_EXPERIMENTAL], [1], [glm needs this for gtx headers]) By adding a configure option 'GLM_ENABLE_EXPERIMENTAL', the decision to use glm/glx is done at one (and the right) place. Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> [1] https://gerrit.libreoffice.org/gitweb?p=libgltf.git
Plausibility check in root source path $ find glm -type f ! -name '*.hpp' ! -name '*.h' ! -name '*.inl' glm/detail/glm.cpp glm/detail/dummy.cpp glm/experimental.hpp.in glm/CMakeLists.txt Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Groovounet
reviewed
Mar 17, 2018
| @@ -82,6 +82,11 @@ option(GLM_TEST_ENABLE_SIMD_AVX "Enable AVX optimizations" OFF) | |||
| option(GLM_TEST_ENABLE_SIMD_AVX2 "Enable AVX2 optimizations" OFF) | |||
| option(GLM_TEST_FORCE_PURE "Force 'pure' instructions" OFF) | |||
|
|
|||
| option(GLM_ENABLE_EXPERIMENTAL "Enable experimental GLM_GTX" OFF) | |||
| configure_file(glm/experimental.hpp.in experimental.hpp @ONLY) | |||
There was a problem hiding this comment.
Why not simply:
if GLM_ENABLE_EXPERIMENTAL
add_definitions(-DGLM_ENABLE_EXPERIMENTAL)
?
There was a problem hiding this comment.
Does that make depending libs happy?
There was a problem hiding this comment.
Why not defining GLM_ENABLE_EXPERIMENTAL in the dependent library that includes GLM then?
|
Experimental code is hidden behind a define to discourage its use or at list to make it clear that the code is experimental so there are risk to use it. Typically, it's not well tested for example. As a consequence, I am not really kine to add a mechanism making it easier to use. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.