Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editing for pk not integer. #763

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix editing for pk not integer. #763

merged 2 commits into from
Feb 22, 2024

Conversation

wlorenzetti
Copy link
Member

@wlorenzetti wlorenzetti commented Feb 21, 2024 •
edited
Loading

Closes: #762

@wlorenzetti wlorenzetti added this to the v3.8 milestone Feb 21, 2024
@wlorenzetti wlorenzetti self-assigned this Feb 21, 2024
@wlorenzetti
Copy link
Member Author

@volterra79 if a use a layer with pk with type varchar i.e. the client does not allow me to edit the primary key field.

@wlorenzetti wlorenzetti marked this pull request as ready for review February 22, 2024 13:16
@wlorenzetti wlorenzetti merged commit 36c20be into dev Feb 22, 2024
4 checks passed
@wlorenzetti wlorenzetti deleted the fix_editing_px_not_int branch February 22, 2024 13:16
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@wlorenzetti @github-actions
Fix editing for pk not integer. (#763)
ff2f421 
* Fix editing for pk not integer.

* Check default value as nextval(NULL).

---------

Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit 36c20be)
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@wlorenzetti @github-actions
Fix editing for pk not integer. (#763)
b715fa4 
* Fix editing for pk not integer.

* Check default value as nextval(NULL).

---------

Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit 36c20be)
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Merged
wlorenzetti added a commit that referenced this pull request Feb 22, 2024
@github-actions @wlorenzetti
Fix editing for pk not integer. (#763) (#764)
525dbe7 
* Fix editing for pk not integer.

* Check default value as nextval(NULL).

---------

Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit 36c20be)

Co-authored-by: Walter Lorenzetti <lorenzetti@gis3w.it>
wlorenzetti pushed a commit that referenced this pull request Feb 22, 2024
@github-actions
Fix editing for pk not integer. (#763) (#765)
a2a2e0e 
* Fix editing for pk not integer.

* Check default value as nextval(NULL).

---------

Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit 36c20be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volterra79 volterra79 Awaiting requested review from volterra79

Assignees

@wlorenzetti wlorenzetti

Labels
backport to v.3.6.x backport to v.3.7.x bug Something isn't working
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

Layer with PK not integer editing saving fails.
1 participant
@wlorenzetti