Use projection definition provide by server (including projection extent) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojection if not register on Application
Raruto
requested changes
Jan 12, 2023
| 'EPSG:32733': GRID_EXTENT_3857, | ||
| 'EPSG:25833': [-2465144.8,3638055.41,2885759.28, 9493779.8] | ||
| }; | ||
|
|
||
| const Projection = function(options={}) { | ||
| if (!options.crs) return null; | ||
| const {epsg, proj4:proj4def, geographic=false, axisinverted=false, extent} = options.crs; // new structure of information crs from server |
There was a problem hiding this comment.
This type of comments (eg. without "external" references) are not very useful, if you really want to communicate something try to be more specific, otherwise it is just additional noise for the reader..
src/app/gui/map/mapservice.js
Outdated
| @@ -1672,6 +1667,11 @@ proto._setupViewer = function(width, height) { | |||
| this.moveDefaultLayersOnTop(zindex); | |||
| }); | |||
|
|
|||
| /** | |||
| * | |||
| * Register remove addLayer | |||
There was a problem hiding this comment.
improve documentation about it (it's quite ambiguous)
# Conflicts: # src/app/core/utils/geo.js # src/app/g3w-ol/g3w.ol.js # src/app/g3w-ol/map/maphelpers.js # src/app/g3w-ol/projection/projections.js # src/app/gui/map/mapservice.js # src/components/MapAddLayer.vue
# Conflicts: # src/components/MapAddLayer.vue
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Feb 1, 2023
Raruto
requested changes
Feb 2, 2023
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to g3w-suite/g3w-admin#430
Add also a way to get Projection object definition using g3w-admin api
/crs/<EPSG_CODE>Example:
Request:
Response:
{ "result": true, "data": { "epsg": 3003, "proj4": "+proj=tmerc +lat_0=0 +lon_0=9 +k=0.9996 +x_0=1500000 +y_0=0 +ellps=intl +towgs84=-104.1,-49.1,-9.9,0.971,-2.917,0.714,-11.68 +units=m +no_defs", "geographic": false, "axisinverted": false, "extent": [ 1226046.6820902952, 4047095.260762165, 1727931.8998958569, 5214000.012210975 ] } }