Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum NodeJS version #30

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jun 7, 2022

package.json

"engines" : { 
  "node" : ">=16.13.2",
  "npm" : ">=8.1.2"
}

Related to: #29
Closes: #26

@volterra79
Copy link
Member

volterra79 commented Jun 7, 2022

@Raruto is better :

"engines" : { 
  "node" : ">=14.18.1",
  "npm" : ">=8.3.0"
}

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 7, 2022

@volterra79 ok, in the meantime I have to figure out how to update npm.

If you are already on that versions, you can also update the package-lock.json file? (so I directly download the latest versions of both and we don't mess with the published lock file).

Raruto

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 7, 2022

@volterra79

If I have not misunderstood each version of node provides an npm version by default (at least this way it works on Windows).

nvm use 14.18.1
node -v
  v14.18.1
npm -v
  6.14.15

Somehow it would also be possible to update npm on its own, but it is much more problematic and cumbersome than using nvm. Is there a particular reason why you need such a high version of npm?

@volterra79
Copy link
Member

@Raruto no reason to update to the high version of npm. In my linux installation npm v8.3.0 come with node v14.18.1. So i sugget to specify only the minimun version of node in "engines" configuration settings.

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 7, 2022

Are you sure you don't have any PATH rules that take precedence?

On my enviroment I have the following association:

Node.js 14.18.1 --> npm 6.14.15

See: https://nodejs.org/en/download/releases/

@volterra79 volterra79 merged commit f352a7a into g3w-suite:dev Jun 7, 2022
@volterra79
Copy link
Member

@Raruto done

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 7, 2022

Tested and working also with:

node: v16.15.0
npm: v8.5.5

g3w-client: v3.4.0

@volterra79
Copy link
Member

@Raruto thanks

@Raruto Raruto added this to the v3.5 milestone Aug 2, 2022
@Raruto Raruto deleted the npm-engines branch August 2, 2022 06:18
Raruto added a commit that referenced this pull request Jan 26, 2023
…or-karma"`)

## Abstract

[yeoman](https://yeoman.io/) is a command line tool useful for starting a new javascript project, at the moment it is no longer necessary, at the moment it is no longer necessary, and indeed most of the time it causes a conflict in the `npm install phase` with the npm engines directive (ref: #30) and its related internal dependency [yeoman-doctor](https://www.npmjs.com/package/yeoman-doctor) (ref: `package-lock.json`)

## List of changes

Delete the following dev dependecies from `package.json`:

- [generator-karma](https://www.npmjs.com/package/generator-karma)
- [generator-browserify](https://www.npmjs.com/package/generator-browserify)
Raruto added a commit that referenced this pull request Aug 16, 2023
…or-karma"`) (#314)

## Abstract

[yeoman](https://yeoman.io/) is a command line tool useful for starting a new javascript project, at the moment it is no longer necessary, at the moment it is no longer necessary, and indeed most of the time it causes a conflict in the `npm install phase` with the npm engines directive (ref: #30) and its related internal dependency [yeoman-doctor](https://www.npmjs.com/package/yeoman-doctor) (ref: `package-lock.json`)

## List of changes

Delete the following dev dependecies from `package.json`:

- [generator-karma](https://www.npmjs.com/package/generator-karma)
- [generator-browserify](https://www.npmjs.com/package/generator-browserify)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of engines property inside package.json
2 participants