Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install util-deprecate package #452

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Install util-deprecate package #452

merged 10 commits into from
Aug 17, 2023

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jul 21, 2023

List of changes

  • add "util-deprecate" dependency to effectively report deprecation of some features to final developer.
  • ref: #365 - drop unusued import "regenerator-runtime"
  • ref: #365 - bump "gulp-uglify" from 1.5.4 to 3.0.2

@volterra79
Copy link
Member

@Raruto need to check if need to add 'util-deprecate' here:

const dependencies = Object.keys(packageJSON.dependencies).filter(dep => dep !== 'vue');

@Raruto
Copy link
Collaborator Author

Raruto commented Aug 9, 2023

@volterra79 I think it shouldn't be necessary to edit the gulpfile:

TEST PERFORMED: util-deprecate is included generated bundle

it should print [G3W] g3sdk.info is deprecated within browser console

/* src/globals.js */

window.g3wsdk = require('app/api');

const deprecate = require('util-deprecate');

window.g3wsdk.info = deprecate(window.g3wsdk.info, '[G3W] g3sdk.info is deprecated');

✅ DEV MODE - localhost:3000

npm i
npm run dev

✅ PROD MODE - localhost:8000

npm i
npm run build

@volterra79 volterra79 merged commit 0f79d9b into dev Aug 17, 2023
@volterra79 volterra79 deleted the util-deprecate branch August 17, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants