Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src/app/eventbus.js (common event emitters) #458

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jul 25, 2023

Motivation

Related to: #92 and #193

Group sparse "global" event emitters into a single location (while waiting for future refactorings).

List of changes

  • add new file: src/app/eventbus.js
  • delete file: src/app/g3w-ol/constants.js (replaced by: app/constant and app/eventbus modules)
  • move src/app/gui/catalog/vue/catalogeventhub.js into app/eventbus (CatalogEventBus)
  • move src/app/gui/relations/vue/relationeventbus.js into app/eventbus (RelationEventBus)
  • move src/app/gui/sidebar/eventbus.js into app/eventbus (SidebarEventBus)

@Raruto Raruto added the refactoring Anything which could result in a API change label Jul 25, 2023
@Raruto Raruto added this to the v3.9 milestone Jul 25, 2023
@Raruto Raruto changed the title Add src/app/eventbus.js (common event emitters) Add src/app/eventbus.js (global event emitters) Jul 25, 2023
@Raruto Raruto changed the title Add src/app/eventbus.js (global event emitters) Add src/app/eventbus.js (common event emitters) Jul 25, 2023
@Raruto Raruto merged commit 240df57 into dev Aug 21, 2023
@Raruto Raruto deleted the refactor-eventbus branch August 21, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants