Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdml file #119

Merged
merged 12 commits into from
Nov 19, 2023
Merged

Gdml file #119

merged 12 commits into from
Nov 19, 2023

Conversation

stewartboogert
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (d41f6b9) 70.62% compared to head (2d18958) 70.50%.

Files Patch % Lines
src/pyg4ometry/gdml/Defines.py 34.04% 31 Missing ⚠️
src/pyg4ometry/gdml/Reader.py 57.14% 24 Missing ⚠️
...g4ometry/gdml/GdmlExpression/GdmlExpressionEval.py 40.00% 9 Missing ⚠️
...ometry/gdml/GdmlExpression/GdmlExpressionParser.py 95.00% 2 Missing ⚠️
.../pyg4ometry/fluka/RegionExpression/RegionParser.py 94.11% 1 Missing ⚠️
src/pyg4ometry/geant4/solid/SolidBase.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   70.62%   70.50%   -0.12%     
==========================================
  Files         140      140              
  Lines       21641    21350     -291     
==========================================
- Hits        15283    15053     -230     
+ Misses       6358     6297      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboogert stewartboogert marked this pull request as ready for review November 19, 2023 15:39
@stewartboogert stewartboogert merged commit c661ef6 into g4edge:main Nov 19, 2023
13 checks passed
@stewartboogert stewartboogert deleted the gdmlFile branch November 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants