Move old tests

[stewartboogert]

Moved most of the tests over

• All input files are from g4testdata
• Some fixtures need work.
• Approximately 600/620 passing

[gipert]

There is a pre-commit check called "python tests naming" that complains about test files not being named test_*.py. I admit it might be too pedantic so feel free to disable it, if you feel like.

[gipert]

So this fixture here:

pyg4ometry/tests/conftest.py

Lines 17 to 25 in 2f1f57b

	@pytest.fixture(scope="session")
	def tmptestdir():
	_tmptestdir.mkdir()
	return _tmptestdir
	def pytest_sessionfinish(session, exitstatus):
	if exitstatus == 0 and _tmptestdir.exists():
	shutil.rmtree(_tmptestdir)

used, for example, here:

pyg4ometry/tests/stl/test_stl_load.py

Line 36 in 2f1f57b

Writer.writeVtkPolyDataAsSTLFile(str(tmptestdir / "T001_Box.stl"), [pd])

sets up a random directory in /tmp for files generated by the test suite and auto-destroys if pytest is successful. The motivation for this is to avoid polluting the local clone with these files and clean them up after every run. It would be ideal to use it everywhere...

[gipert]

Non-Python files in features/ have been committed by mistake, I presume?

[gipert]

I see you depend on PyROOT for some tests, which is not available in CI. We should discuss how to install this dependency, if it's really necessary...

[stewartboogert]

There is a pre-commit check called "python tests naming" that complains about test files not being named test_*.py. I admit it might be too pedantic so feel free to disable it, if you feel like.

I was going to ask. Fixtures is some cases is an excellent solution , but it does making running some code outside of purest cumbersome. I'll disable for now

[stewartboogert]

I see you depend on PyROOT for some tests, which is not available in CI. We should discuss how to install this dependency, if it's really necessary...

There is a converter from root and it would be great to test against. A standard root install in the docker image would be outstanding. Does not need to be anything magical, just working with the python we use.

Should I disable them for now?

[stewartboogert]

So this fixture here:

pyg4ometry/tests/conftest.py

Lines 17 to 25 in 2f1f57b

	@pytest.fixture(scope="session")
	def tmptestdir():
	_tmptestdir.mkdir()
	return _tmptestdir
	def pytest_sessionfinish(session, exitstatus):
	if exitstatus == 0 and _tmptestdir.exists():
	shutil.rmtree(_tmptestdir)

used, for example, here:

pyg4ometry/tests/stl/test_stl_load.py

Line 36 in 2f1f57b

Writer.writeVtkPolyDataAsSTLFile(str(tmptestdir / "T001_Box.stl"), [pd])

sets up a random directory in /tmp for files generated by the test suite and auto-destroys if pytest is successful. The motivation for this is to avoid polluting the local clone with these files and clean them up after every run. It would be ideal to use it everywhere...

Exellent I was going to ask how to do this. I am currently littering the directory structure with files which I want to suppress.

[gipert]

There is a converter from root and it would be great to test against. A standard root install in the docker image would be outstanding. Does not need to be anything magical, just working with the python we use.

Should I disable them for now?

Yes, please. Could you open an issue about PyROOT to keep track of it?

[codecov]

Codecov Report

Merging #36 (79dd648) into main (e3f8e29) will increase coverage by 44.36%.
The diff coverage is 61.11%.

@@             Coverage Diff             @@
##             main      #36       +/-   ##
===========================================
+ Coverage   24.24%   68.61%   +44.36%     
===========================================
  Files         144      144               
  Lines       21024    21036       +12     
===========================================
+ Hits         5098    14434     +9336     
+ Misses      15926     6602     -9324     

Impacted Files	Coverage Δ
src/pyg4ometry/geant4/Registry.py	66.60% <46.15%> (+41.79%)	⬆️
src/pyg4ometry/fluka/body.py	84.63% <100.00%> (+57.79%)	⬆️
src/pyg4ometry/fluka/preprocessor.py	83.43% <100.00%> (+64.33%)	⬆️
...c/pyg4ometry/visualisation/VisualisationOptions.py	83.87% <100.00%> (+51.61%)	⬆️

... and 82 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more