Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oce empty tesselation #38

Merged
merged 7 commits into from
Jul 3, 2023

Conversation

stewartboogert
Copy link
Member

Occasionally Opencascade tessellation are None objects. Guard against this until a fuller fix can be found

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #38 (2a9e57d) into main (2f1f57b) will increase coverage by 0.00%.
The diff coverage is 15.78%.

@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   24.27%   24.28%           
=======================================
  Files         145      145           
  Lines       21045    21050    +5     
=======================================
+ Hits         5108     5111    +3     
- Misses      15937    15939    +2     
Impacted Files Coverage Δ
src/pyg4ometry/convert/geant42Fluka.py 2.10% <0.00%> (ø)
src/pyg4ometry/visualisation/VtkViewer.py 8.61% <0.00%> (ø)
src/pyg4ometry/convert/oce2Geant4.py 91.35% <60.00%> (-1.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gipert
Copy link
Member

gipert commented Jul 2, 2023

Doesn't this conflict with #39?

@stewartboogert stewartboogert merged commit 42b103e into g4edge:main Jul 3, 2023
13 checks passed
@stewartboogert stewartboogert deleted the oceEmptyTesselation branch July 4, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants