Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression fix #40

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Expression fix #40

merged 2 commits into from
Jul 3, 2023

Conversation

stewartboogert
Copy link
Member

Class for GDML expressions was complex. Laurie refactored on bitbucket. Same code here just with pre-commit checks.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #40 (515fef5) into main (b8779e7) will decrease coverage by 0.04%.
The diff coverage is 39.19%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   24.27%   24.23%   -0.04%     
==========================================
  Files         145      144       -1     
  Lines       21045    21019      -26     
==========================================
- Hits         5108     5095      -13     
+ Misses      15937    15924      -13     
Impacted Files Coverage Δ
...g4ometry/gdml/GdmlExpression/GdmlExpressionEval.py 63.84% <ø> (ø)
...4ometry/gdml/GdmlExpression/GdmlExpressionLexer.py 100.00% <ø> (ø)
...ometry/gdml/GdmlExpression/GdmlExpressionParser.py 62.12% <ø> (ø)
...metry/gdml/GdmlExpression/GdmlExpressionVisitor.py 53.12% <ø> (ø)
src/pyg4ometry/gdml/GdmlExpression/__init__.py 100.00% <ø> (ø)
src/pyg4ometry/gdml/Reader.py 3.88% <0.00%> (-0.01%) ⬇️
src/pyg4ometry/geant4/DivisionVolume.py 6.81% <0.00%> (ø)
src/pyg4ometry/geant4/__init__.py 100.00% <ø> (ø)
src/pyg4ometry/geant4/solid/Scaled.py 27.58% <ø> (ø)
src/pyg4ometry/geant4/Registry.py 24.81% <21.42%> (+0.04%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stewartboogert stewartboogert merged commit e3f8e29 into g4edge:main Jul 3, 2023
13 checks passed
@stewartboogert stewartboogert deleted the expressionFix branch July 4, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant