Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycgal : (feature) Half space upgrades #95

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

stewartboogert
Copy link
Member

H-Rep (half space) representation code. What is needed for CAD to FLUKA conversion

  • Extended Cartesian exact rational ECER kernel
  • Standard classes using ECER kernel (Nef_polyhedron, Polyhedron, Surface_mesh)
  • Conversion from Surface_mesh_EPECK to _ECER

@stewartboogert stewartboogert added the enhancement New feature or request label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #95 (97e91b7) into main (643c339) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 42.30%.

❗ Current head 97e91b7 differs from pull request most recent head be97499. Consider uploading reports for the commit be97499 to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   70.65%   70.69%   +0.03%     
==========================================
  Files         139      139              
  Lines       21612    21571      -41     
==========================================
- Hits        15271    15250      -21     
+ Misses       6341     6321      -20     
Files Changed Coverage Δ
src/pyg4ometry/cli.py 5.17% <0.00%> (ø)
src/pyg4ometry/pycgal/HalfPlane.py 41.66% <41.66%> (ø)
src/pyg4ometry/pycgal/__init__.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stewartboogert stewartboogert force-pushed the halfPlane branch 2 times, most recently from 7b2fb2f to d7ceda2 Compare August 27, 2023 13:23
@stewartboogert stewartboogert marked this pull request as ready for review August 27, 2023 16:27
H-Rep (half space) representation code
- Extended Cartesian exact rational ECER kernel
- Standard classes using ECER kernel (Nef_polyhedron, Polyhedron, Surface_mesh)
- Conversion from Surface_mesh_EPECK to _ECER
@stewartboogert stewartboogert merged commit 8624ad8 into g4edge:main Aug 27, 2023
13 checks passed
@stewartboogert stewartboogert deleted the halfPlane branch August 27, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant