Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluka : (improvement) improvements for running fluka #99

Merged
merged 17 commits into from
Nov 19, 2023

Conversation

stewartboogert
Copy link
Member

  • remove spurious printout
  • start of neutron group transport data file
  • loading of MG lowmat cross sections
  • convert of tracking mgdraw dump files to vtk polydata
  • convert usrbin to vtk image/grid data

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Attention: 421 lines in your changes are missing coverage. Please review.

Comparison is base (c661ef6) 70.50% compared to head (4dee3fc) 70.42%.

Files Patch % Lines
src/pyg4ometry/analysis/flukaData.py 43.20% 142 Missing ⚠️
src/pyg4ometry/analysis/Data.py 18.42% 124 Missing ⚠️
src/pyg4ometry/visualisation/VtkViewerNew.py 13.88% 62 Missing ⚠️
src/pyg4ometry/fluka/mgnfield.py 0.00% 32 Missing ⚠️
src/pyg4ometry/analysis/Plot.py 27.77% 26 Missing ⚠️
src/pyg4ometry/fluka/fluka_registry.py 56.75% 16 Missing ⚠️
src/pyg4ometry/fluka/elcfield.py 0.00% 9 Missing ⚠️
src/pyg4ometry/visualisation/Convert.py 14.28% 6 Missing ⚠️
src/pyg4ometry/visualisation/ViewerBase.py 33.33% 2 Missing ⚠️
src/pyg4ometry/convert/geant42FlukaBake.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   70.50%   70.42%   -0.09%     
==========================================
  Files         140      144       +4     
  Lines       21350    21917     +567     
==========================================
+ Hits        15053    15434     +381     
- Misses       6297     6483     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboogert stewartboogert marked this pull request as ready for review November 19, 2023 22:55
@stewartboogert stewartboogert merged commit b61fbc4 into g4edge:main Nov 19, 2023
13 checks passed
@stewartboogert stewartboogert deleted the flukaRunning branch November 19, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant