Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ElementaryOS #103

Closed
murbanowicz opened this issue Nov 19, 2019 · 11 comments
Closed

Port to ElementaryOS #103

murbanowicz opened this issue Nov 19, 2019 · 11 comments

Comments

@murbanowicz
Copy link

Thanks for great tool.
Do you think you could port it to ElementaryOS somehow?

@scherepanov
Copy link
Contributor

ElementaryOS is quite different beast, no full-fledged gnome-shell. It looks by far more for complete rewrite, then port.
Also, current code structure is bad. At least gTile have to be 100% rewritten in TypeScript. Then, at least in theory it is possible to talk about some kind of port.
Anyway, I am way too busy and cannot get even little time to implement some ideas/bug fixes in current codebase. That is the largest problem.

@murbanowicz
Copy link
Author

Do you need help with TypeScript?

@scherepanov
Copy link
Contributor

Yes, gTile need to be moved to TypeScript.
There is almost working port to TypeScript, if you can complete it would be of a huge help.
It is #93
If you can join efforts with @JMurph2015 and complete it, would be a huge deal.

@scherepanov
Copy link
Contributor

After reading about Elementary OS, I have an impression that very few changes needed to have gTile working there.
May be we should consider port to Elementary OS in a future.
Will return to this topic after finishing rewriting in typescript.

@murbanowicz
Copy link
Author

Oh! Great! I have already left the message on the TS migration with asking for branch etc. I will try to help!

@murbanowicz
Copy link
Author

Hi!
Any plans for doing that? It did sound promising, but looks like you didn't/don't have time for that?

@scherepanov
Copy link
Contributor

Sorry, had no time to actually do anything.
Your fate is in your hands. Create port, submit PR, or make your own repo.

@JMurph2015
Copy link
Contributor

Hi @murbanowicz! I've been pretty busy with some personal life stuff recently so the full rewrite port to TS has been on hold, but recently the project has been incrementally converting files to Typescript it seems, so it may be possible when more of that refactoring is done. However since this is a all-volunteer project, the best way to ensure something happens is to pitch in.

@scherepanov
Copy link
Contributor

Port to TS pretty much done.
Now, feel free to port to Elementary OS!

@JMurph2015
Copy link
Contributor

Just while we're on the topic, the reason I say mostly is because my biggest blocker on making a Cinnamon port was that we would need to abstract out a settings interface, and one of the few JS holdouts is the the settings.js file.

The long term dream I had for being able to support Cinnamon and the like was to refactor GTile into a) core logic (grids, autotiling, generic idea of resizing a window) and b) desktop specific action interfaces (settings, hotkeys, resizing windows, etc) so that we could just implement a new DE handler for some of these popular Gnome derivative desktops. However, that would require quite an ambitious undertaking of restructuring the extension into more modular components like what was done with the TileSpec class.

@scherepanov
Copy link
Contributor

Sweet dreams...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants