Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong tests #25

Open
RealWeeks opened this issue Jul 14, 2016 · 2 comments
Open

Wrong tests #25

RealWeeks opened this issue Jul 14, 2016 · 2 comments

Comments

@RealWeeks
Copy link
Member

Test should be for what they are doing in the lab, not for what they have already done - via @gaand
@jrhorn424
Copy link
Contributor

I would add that the tests for what they do in the lab should be in addition to not instead of what they have already done.

@gaand
Copy link

gaand commented Oct 19, 2016

The change from object literal to constructor makes your suggestion quite difficult to work.

I suppose the tests could switch on whether what comes out of lib/hero.js is typeof 'function'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrhorn424 @gaand @RealWeeks