Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Incorrect http re-assembly #10
Attached is pcap file that is incorrectly re-assembled into http stream.
As seen in this screenshot, the body of DELETE request is not correct:
To make sure it's not a bad pcap file, I looked at packets using http://www.tastycocoabytes.com/cpa/.
This is how body of the request should look like:
I think https://github.com/ga0/netgraph/blob/master/ngnet/httpstream.go#L74 might be an issue.
It merely sends r for processing.
According to https://godoc.org/github.com/google/gopacket/tcpassembly#Stream, Reassembly slice will be re-used, so probably should make a copy of r before sending.