This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Develop proto structural and ranges #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both attributes for first types of structural variants (DUP,DEL) as well as the necessary start, end intervals for matching imprecise positions
|
closing, since develop-porto is better target branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements both the attributes for querying a subset of structural variants, such as currently possibly represented through the GA4GH variants schema, as well as the
start[1..2],end[0..2]modifications to allow matching variants of imprecise alert, end and sequence composition.The need for these changes as well as possible ways to implement them have been discussed previously:
Also, the moving ahead with structural variant definitions in both schemas and Beacon has been discussed with the VMC team (@reece, @sarahhunt), who at the present focus on the representation of precise variants.
Technical note: This changes the index numbers of the develop-proto branch; however, in this case it seems acceptable since proto had not been implemented as master.