Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document query request body and parameter types #48

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

jfuerth
Copy link
Contributor

@jfuerth jfuerth commented Oct 14, 2020

Addresses issue #47

@jmarshall
Copy link

This PR does indeed insert a specification of the POST message body into the places I expected to find it in search-api.yaml and SEARCHSPEC.md. (I haven't reviewed the text added in detail, as I would need to have been seconded onto the PRC to be in a position to do that.)

@mcupak
Copy link
Collaborator

mcupak commented Oct 16, 2020

LGTM! I made a minor change to the example so that it renders correctly on SwaggerHub and in Swagger Editor.

@mcupak mcupak merged commit 177b2a4 into develop Oct 16, 2020
@mcupak mcupak deleted the issue-47-search-request-body branch October 16, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants