Skip to content

Commit

Permalink
Remove pagination, close #71
Browse files Browse the repository at this point in the history
  • Loading branch information
mcupak committed Aug 19, 2019
1 parent 8dcd8de commit 8167eb9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 29 deletions.
7 changes: 6 additions & 1 deletion README.md
Expand Up @@ -10,12 +10,17 @@ See the swagger editor to view our [schema](https://editor.swagger.io/?url=https

Use [Swagger Validator Badge](https://github.com/swagger-api/validator-badge) to validate the YAML file.

# How to contribute
## How to contribute

See [CONTRIBUTING.md](CONTRIBUTING.md).

If a security issue is identified with the specification, please send an email to security-notification@ga4gh.org detailing your concerns.

## Implementation decisions

1. Don't prescribe pagination ([#71](https://github.com/ga4gh-discovery/ga4gh-service-registry/issues/71)).
1. Don't compromise design in favour of static no-code implementation ([#71](https://github.com/ga4gh-discovery/ga4gh-service-registry/issues/71)).

## More info

- [Global Alliance for Genomics and Health](http://genomicsandhealth.org)
33 changes: 5 additions & 28 deletions service-registry.yaml
Expand Up @@ -16,28 +16,16 @@ paths:
get:
tags:
- services
summary: Get page of services
parameters:
- name: page
in: query
description: Page token
required: false
schema:
type: string
example: 'NDMyNzQyODI3OTQw'
summary: List services in the registry
responses:
'200':
description: Success
content:
application/json:
schema:
properties:
content:
type: array
items:
$ref: '#/components/schemas/Service'
pagination:
$ref: '#/components/schemas/Pagination'
type: array
items:
$ref: '#/components/schemas/Service'
'401':
$ref: '#/components/responses/Unauthorized'
'403':
Expand Down Expand Up @@ -137,17 +125,6 @@ components:
example: 'https://ga4gh-example-service.com'
required:
- url
Pagination:
type: object
properties:
previousPage:
type: string
format: uri
example: 'https://ga4gh-example-service.com?page=dXNlcjpVMEc5V0ZYTlo'
nextPage:
type: string
format: uri
example: 'https://ga4gh-example-service.com?page=NDMyNzQyODI3OTQw'
Error:
type: object
properties:
Expand Down Expand Up @@ -176,4 +153,4 @@ components:
message:
type: string
description: Description of the error or information.
example: 'Argument x must be greater than zero'
example: 'Argument x must be greater than zero'

0 comments on commit 8167eb9

Please sign in to comment.