Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percent encoding issue with IDs #222

Open
denis-yuen opened this issue Jun 14, 2022 · 0 comments
Open

percent encoding issue with IDs #222

denis-yuen opened this issue Jun 14, 2022 · 0 comments
Labels
help wanted question security Pull requests that address a security vulnerability
Milestone

Comments

@denis-yuen
Copy link
Member

denis-yuen commented Jun 14, 2022

The current specification is pretty descriptive rather then prescriptive when it comes to ID format.

We have in the main readme

ID: globally unique across systems and also identifies the system that it came from (ex: 123456323@agora.broadinstitute.org )

In #164 we have

To ensure that versioned TRS URIs can be unambiguously parsed by clients, any / characters potentially occurring in tool and tool version identifiers would need to be percent-/URL-encoded before sharing a versioned TRS URI.

This breaks out this issue for discussion. For background, Dockstore uses percent encoded slashes but this can place a burden on implementer of the standard to handle these in a secure way

┆Issue is synchronized with this Jira Story
┆Project Name: Zzz-ARCHIVE GA4GH tool-registry-service
┆Issue Number: TRS-57

@denis-yuen denis-yuen added help wanted question security Pull requests that address a security vulnerability labels Jun 14, 2022
@denis-yuen denis-yuen added this to the v2.1 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted question security Pull requests that address a security vulnerability
Projects
None yet
Development

No branches or pull requests

1 participant