Epic #480 "Create Adjacency" #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we still need the homology flag to distinguish between imprecision due to assay limitations vs equivalence of sequences on either side of the adjacency? |
|
I don't know; do we? The homology flag was removed a while ago, so I don't remember why exactly that change was made. I understand the two scenarios you are describing, but is this distinction important? I haven't explored this deeply, but it seems to me that you can infer when each of these situations are taking place from the sequence content; and if you cannot infer it, that it doesn't make a difference. Maybe a good conversation topic for Connect. For now, I will add it back in as an optional property, and will open #489 for discussion and use cases on this topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #480 "Create Adjacency"
related to #429