Skip to content

Commit

Permalink
END { done_testing } affords no protection.
Browse files Browse the repository at this point in the history
You might as well use no_plan and not be fooled into thinking you're protected... or anger test library authors.
  • Loading branch information
schwern committed Sep 23, 2011
1 parent 8404761 commit 8b62155
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions t/01-simple.t
@@ -1,7 +1,7 @@
#!/usr/bin/env perl -w
use strict;

use Test::More;
use Test::More 'no_plan';
use Data::Dumper;
use Scalar::Util qw(blessed);

Expand Down Expand Up @@ -330,9 +330,6 @@ require_ok 'Class::Rebless';
Class::Rebless->rebless($obj_1, 'Foo');
}

# in an END{} because there's a previously-registered END{} for
# Test::NoWarnings, potentially -- rjbs, 2011-03-21
END { done_testing; }

sub my_custom_editor {
my ($obj, $namespace) = @_;
Expand Down

0 comments on commit 8b62155

Please sign in to comment.