Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Version @hapi/hapi #11

Closed
wants to merge 4 commits into from
Closed

Upgrade Version @hapi/hapi #11

wants to merge 4 commits into from

Conversation

PauloFerreira25
Copy link

Hello Sirs,

Please accept my pull request.

I upgraded the hapi version to the latest one and made the code consistent with this version.

I also included the eslint to keep the default formatting of the code.

Thank you very much for your attention.

@gabaroar
Copy link
Owner

Hi Paulo,

Thank you for the pull request. Would you be interested in taking over this repo as I no longer work in JS or Hapi? I would be happy to transfer it to you.

@PauloFerreira25
Copy link
Author

Hello gabaroar

I would be honored to receive your repository.

Another possibility, would be to add me as administrator, so keep the forks.

Please do not forget the permission also on npmjs.com

Thank you very much for your attention.

@PauloFerreira25
Copy link
Author

Hello Friend,

I just discovered that this plugin is no longer needed. :(

Hapijs 18+ contains a native implementation of cors.
Ref: outmoded/discuss#262

Basically, just do:

const server = Hapi.server ({
     port: 3000,
     host: 'localhost',
     routes: {
       cors: {origin: ['*'], additionalHeaders: ['X-Custom-Header']}
     }
   })

I recommend, change the Read Me of this project to notify this.

Thank you very much for your attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants