Supported the deceptive Internet Explorer 12 #47
Conversation
Internet Explorer 12 disguises as Chrome 36, but adds a new Edge/x.x token. https://gist.github.com/jacobrossi/c9699b27df2f4e97c0bd Sneaky.
|
Will review this ASAP. |
|
So far changes look good, will make a comment later, but can you add a new test for this UA please? Also, you do know that technically all browsers are deceptive, right? :P |
|
I will add a test. Yeah, of course, but some are much more deceptive than others. This one is the most deceptive I know. |
A simple copy and paste of the Internet Explorer 11 test and a few digit change.
|
Done. |
| @@ -31,7 +31,8 @@ | |||
| jQuery.uaMatch = function( ua ) { | |||
| ua = ua.toLowerCase(); | |||
|
|
|||
| var match = /(opr)[\/]([\w.]+)/.exec( ua ) || | |||
| var match = /(edge)\/([\w.]+)/.exec( ua ) || | |||
| /(opr)[\/]([\w.]+)/.exec( ua ) || | |||
There was a problem hiding this comment.
Nit: can you line this line up with the Chrome line below it please?
|
Everything looks good, just that one nit there and this can be merged. |
There were only whitespace characters, while the rest of the lines use a weird combination of tabs and spaces, but general consistency within a file comes first.
|
Whitespace characters and a tab character within the same line? Wow. This looks so wrong. |
|
I honestly thought I fixed that already, but I guess not. I will right after I merge this. Thanks for the contribution! |
|
Glad to help. :) |
|
And for the record, I agree, IE 12 is very deceptive with this update. |
Internet Explorer 12 disguises as Chrome 36, but adds a new Edge/x.x token.
https://gist.github.com/jacobrossi/c9699b27df2f4e97c0bd
Sneaky.