Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not working. #1

Closed
kadamski opened this issue Mar 16, 2015 · 20 comments
Closed

Colors not working. #1

kadamski opened this issue Mar 16, 2015 · 20 comments

Comments

@kadamski
Copy link

After searching, my result looks like this:

[1;31mdrivers/mmc/core/debugfs.c[0m[K
[1;30m 200 [0m[K-
[1;30m 201 [0m[K-   mmc_claim_host(host);
[1;30m 202 [0m[K-   mmc_set_clock(host, (unsigned int) val);
[1;30m 203 [0m[K:2: [32;40mmmc_release_host[0m[K(host);
[1;30m 204 [0m[K-
[1;30m 205 [0m[K-   return 0;
[1;30m 206 [0m[K-}

There are no colors and escape characters are seen so obviously something went wrong. Tested on both vim and gvim 7.4 on Linux.

@egradman
Copy link

same on OSX console vim

@gabesoft
Copy link
Owner

Looks like vim is not picking up the syntax highlighting. Can you verify that the search results window has filetype=agsv? Run set ft? in the search window

@egradman
Copy link

filetype=agsv <— that’s what I see.

On Mon, Mar 16, 2015 at 2:51 PM, Gabriel Adomnicai <notifications@github.com

wrote:

Looks like vim is not picking up the syntax highlighting. Can you verify
that the search results window has filetype=agsv? Run set ft? in the search
window


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@gabesoft
Copy link
Owner

can you also check conceallevel and concealcursor, they should be 3 and nvic respectively in the search window

@egradman
Copy link

they are

On Mon, Mar 16, 2015 at 6:01 PM, Gabriel Adomnicai <notifications@github.com

wrote:

can you also check conceallevel and concealcursor, they should be 3 and
nvic respectively in the search window


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@gabesoft
Copy link
Owner

One more thing to check is to make sure your vim is compiled with the conceal feature. When you run :version do you see +conceal ?

@kadamski
Copy link
Author

In my case filetype was not set to any value, setting it manually fixed the problem. And the reason for that was that I did not restart my vim after doing "BundleInstall". It seems that my vundle failed at inserting ftdetect rules after installation.

@egradman
Copy link

Yup, it has +conceal. I installed this plugin using pathogen, btw.

On Tue, Mar 17, 2015 at 12:48 AM, Krzysztof A. Adamski <
notifications@github.com> wrote:

In my case filetype was not set to any value, setting it manually fixed
the problem. And the reason for that was that I did not restart my vim
after doing "BundleInstall". It seems that my vundle failed at inserting
ftdetect rules after installation.


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@gabesoft
Copy link
Owner

@egradman not sure why the syntax highlight is not picking up. Do you mind pasting a few lines from the search results window.

@egradman
Copy link

here’s a screenshot. The colors of the brackets are due to rainbow-parens
(come to think of it, perhaps if I disable that…)

https://www.dropbox.com/s/3ay46jywg7unz6x/Screenshot%202015-03-17%2014.11.07.png?dl=0

On Tue, Mar 17, 2015 at 1:45 PM, Gabriel Adomnicai <notifications@github.com

wrote:

@egradman https://github.com/egradman not sure why the syntax highlight
is not picking up. Do you mind pasting a few lines from the search results
window.


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@egradman
Copy link

I just restarted vim with just your plugin and it works fine, so its
definitely a conflict with something else I’m running. I’ll figure out
which one it is and report back.

On Tue, Mar 17, 2015 at 2:11 PM, Eric Gradman eric@gradman.com wrote:

here’s a screenshot. The colors of the brackets are due to rainbow-parens
(come to think of it, perhaps if I disable that…)

https://www.dropbox.com/s/3ay46jywg7unz6x/Screenshot%202015-03-17%2014.11.07.png?dl=0

On Tue, Mar 17, 2015 at 1:45 PM, Gabriel Adomnicai <
notifications@github.com> wrote:

@egradman https://github.com/egradman not sure why the syntax
highlight is not picking up. Do you mind pasting a few lines from the
search results window.


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@egradman
Copy link

Okay, it's definitely a conflict with https://github.com/luochen1990/rainbow

@gabesoft
Copy link
Owner

@egradman cool, that's good to know. I'll look at the rainbow plugin when I get home and see if there's anything I can do in vim-ags to eliminate the conflict.

@gabesoft
Copy link
Owner

Actually, I think it's just a matter of configuring the g:rainbow_conf option to disable rainbow parens for filetypes of agsv. Something like let g:rainbow_conf = { 'separately' : { 'agsv' : 0 } } should do the trick

@egradman
Copy link

so it would appear. this doesn’t seem to work however but I don’t think
it’s the fault of your plugin.

On Tue, Mar 17, 2015 at 3:50 PM, Gabriel Adomnicai <notifications@github.com

wrote:

Actually, I think it's just a matter of configuring the g:rainbow_conf
option to disable rainbow parens for filetypes of agsv. Something like let
g:rainbow_conf = { 'separately' : { 'agsv' : 0 } } should do the trick


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@gabesoft
Copy link
Owner

I've tried the rainbow plugin and it seems to work properly. After I added this to my vimrc

let g:rainbow_conf = {
      \ 'separately' : { 'agsv' : 0 }
      \ }
let g:rainbow_active = 1

the search results picked up the correct syntax. You may need to restart vim for the changes to take effect.

@egradman
Copy link

I may have spoken too soon. I’m currently running vim with ONLY your
plugin and I’m seeing the same results...

What threw me off is that it seems to be dependent on my cwd when I run the
command.

Two fresh sessions of vim in two different directories (in two adjacent
iTerm windows): one renders correctly, one renders incorrectly.

On Wed, Mar 18, 2015 at 11:13 AM, Gabriel Adomnicai <
notifications@github.com> wrote:

I've tried the rainbow plugin and it seems to work properly. After I added
this to my vimrc

let g:rainbow_conf = {
\ 'separately' : { 'agsv' : 0 }
\ }
let g:rainbow_active = 1

the search results picked up the correct syntax. You may need to restart
vim for the changes to take effect.


Reply to this email directly or view it on GitHub
#1 (comment).

Eric Gradman
CTO & Mad Inventor
P: 213-268-6253 | W: twobitcircus.com http://www.twobitcircus.com/
TW: @egradman http://www.twitter.com/egradman

TWO BIT CIRCUS
Engineering Entertainment

Inventors | Developers | Performers

@gabesoft
Copy link
Owner

What do the results look for the one that renders incorrectly?

@megalithic
Copy link

👍 that mostly fixed it for me, thanks Gabriel.

@gabesoft
Copy link
Owner

I'll close this as it seems to be a configuration issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants