Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neovim] add async support? #17

Closed
liujoey opened this issue Sep 2, 2015 · 5 comments
Closed

[Neovim] add async support? #17

liujoey opened this issue Sep 2, 2015 · 5 comments

Comments

@liujoey
Copy link

liujoey commented Sep 2, 2015

Would you like to add async support for Neovim and vim-dispatch? One example could be found from here

With the async support, it could also improve performance, because user doesn't need to wait for all results to be fetched.

@gabesoft
Copy link
Owner

gabesoft commented Sep 3, 2015

That sounds good. I think async support would be a welcome improvement. I'm a bit busy with other projects right now. But, I'll get to this as soon as I have some spare time.

@gabesoft
Copy link
Owner

I've been playing with the async support for neovim. I have a potential implementation here 00880a6 on the async-search branch. The only thing is that it doesn't seem faster that the sync version. Take a look when you have some time.

@liujoey
Copy link
Author

liujoey commented Oct 26, 2015

It definitely faster, I tried it on a very large java project (my current working project), and when I search a very common word, your master branch took about 10-15 seconds before it can populate any result. While with the async branch, it shows result within 1 second, and I can start scrolling down while it's adding more results to the buffer. Impressive!

@gabesoft
Copy link
Owner

Sounds good. Then it's worth integrating this change it into the master branch.

@liujoey
Copy link
Author

liujoey commented Oct 27, 2015

Thanks for your great work. I will close this issue.

@liujoey liujoey closed this as completed Oct 27, 2015
gabesoft added a commit that referenced this issue Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants