Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace SPDLOG_DEBUG/TRACE macro from force_log to log #65

Closed
theambient opened this issue Mar 24, 2015 · 4 comments
Closed

replace SPDLOG_DEBUG/TRACE macro from force_log to log #65

theambient opened this issue Mar 24, 2015 · 4 comments

Comments

@theambient
Copy link
Contributor

because it is impossible to handle log level runtime otherwise.
@gabime
Copy link
Owner

gabime commented Mar 24, 2015

Log levels can be set at runtime..
The idea is that the DEBUG/TRACE macros will always appear if SPDLOG_DEBUG_ON is defined, no matter the actual level.

@theambient
Copy link
Contributor Author

theambient commented Mar 24, 2015 via email

@gabime
Copy link
Owner

gabime commented Mar 24, 2015

Ok. Lets try those suggestions. Pull would be nice.

@theambient theambient mentioned this issue Mar 26, 2015
Merged
gabime added a commit that referenced this issue Mar 26, 2015
@gabime
Merge pull request #70 from theambient/master
9603c2a 
issue #65: added macroses like SPDLOG_TRACE but with no force
@gabime
Copy link
Owner

gabime commented Apr 8, 2015

Fixed in 9603c2a

@gabime gabime closed this as completed Apr 8, 2015
bachittle pushed a commit to bachittle/spdlog that referenced this issue Dec 22, 2022
Plug the SpanProcessor into the Tracer implementation (gabime#65)
132aca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theambient @gabime