Correctly guard SetHandleInformation API call

[sylveon]

__cplusplus_winrt only detected C++/CX (which can be used without compiling for UWP, SetHandleInformation would be available in those cases), and did not detect native UWP C++. This patch fixes that by using the WINAPI_FAMILY_PARTITION macro in the Windows SDK headers in the same way those headers remove SetHandleInformation in UWP builds.

[sylveon]

How would you feel about adding a [[maybe_unused]] to silence warnings on /W4 with MSVC?

[gabime]

How would you feel about adding a [[maybe_unused]] to silence warnings on /W4 with MSVC?

Which warnings specifically? The problem is spdlog is c++11

[gabime]

On second thought, What if windows sdk is not installed? will this break?

[sylveon]

Without the windows sdk, sethandleinformation or any windows header isn't available at all. The warning is C4100, and maybe_unused could be conditionally enabled using the preprocessor (or you could manually disable the warning using pragmas)

…

On Mon, Nov 4, 2019, 04:04 Gabi Melman ***@***.***> wrote: On second thought.What if windows sdk is not installed? will this break? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1296?email_source=notifications&email_token=ABRELNTV74JU23SUTLT3HWLQR7QSPA5CNFSM4JIOWSQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC6STBA#issuecomment-549267844>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRELNRVUIZPT4SGQMCVWGDQR7QSPANCNFSM4JIOWSQA> .

[gabime]

could manually disable the warning using pragmas

Before which line?

[gabime]

Without the windows sdk, sethandleinformation or any windows header isn't
available at all.

Are you sure? I dont see any mention of this here

[sylveon]

Around the method implementation's body since the warning is related to a parameter not being used.

…

On Mon, Nov 4, 2019, 08:55 Gabi Melman ***@***.***> wrote: Without the windows sdk, sethandleinformation or any windows header isn't available at all. Are you sure? I dont see any mention of this here <https://docs.microsoft.com/en-us/windows/win32/api/handleapi/nf-handleapi-sethandleinformation> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1296?email_source=notifications&email_token=ABRELNXO7Q7ZNJUN6KKDA4TQSASVDA5CNFSM4JIOWSQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7KA3A#issuecomment-549363820>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRELNV3ILW54VTPHYYAI5TQSASVDANCNFSM4JIOWSQA> .

[gabime]

You mean FILE *f not being used if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP | WINAPI_PARTITION_SYSTEM is not satisfied ?

[sylveon]

Correct, hence maybe_unused

…

On Mon, Nov 4, 2019, 09:03 Gabi Melman ***@***.***> wrote: You mean FILE *f not being used if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP | WINAPI_PARTITION_SYSTEM is not satisfied ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1296?email_source=notifications&email_token=ABRELNSB32B4Q6NW2ZLHHMTQSATSPA5CNFSM4JIOWSQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7K3ZQ#issuecomment-549367270>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRELNRVZDGVPBA5BLEXA53QSATSPANCNFSM4JIOWSQA> .

[gabime]

The real problem is that this function would silently..

[gabime]

Here is my shot at it. If SPDLOG_PREVENT_CHILD_FD is not defined(default) - then the entrire function will not be defined.

If SPDLOG_PREVENT_CHILD_FD is defined under winrt - then the lib won't compile - which is way better than failing silently.

[sylveon]

Sounds like a valid option.