-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the SPDLOG_USE_WCHAR tweak to enable support for Unicode names on Windows. #192
Conversation
I reverted. didn't compile properly under vs2015 |
@gabime What was the error? I'll install vs2015 and test later today. |
an I will make some changes and merge again soon |
@gabime This include caused errors in tests. See https://travis-ci.org/gabime/spdlog/jobs/120374514 We need to find a fallback method for turning wstring to string that should be executed in case compiler does not support codecvt. The codecvt version should be preferred though. |
right. seems like gcc don't have this file. |
I think I will add something like #if defined(_WIN32) && defined(SPDLOG_USE_WCHAR)
#include <locale>
#include <codecvt>
#endif |
@gabime It's rather libstdc++. But I read somewhere that modern versions do support it. Not sure how could we figure this out exactly, but your change seems sane. |
@gabime Did this fix work for you? |
@Kentzo sorry, I did not have time to get to it. |
Refs #111