Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of C++14-specific std::make_unique from mongo_sink.h #2025

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

jabartek
Copy link
Contributor

@jabartek jabartek commented Aug 2, 2021

mongo_sink.h used std::make_unique instead of spdlog::details::make_unique, thus making it impossible to compile a project under C++11 which spdlog itself targets. While mongocxx requires use of polyfills to work under C++11, it should not be a case with a spdlog project that just links with it

@jabartek
Copy link
Contributor Author

jabartek commented Aug 2, 2021

I'm not sure how exactly #1981 passed the GCC_VERSION=4.8 BUILD_TYPE=Release CPP=11 check - maybe this should be looked into as well. Sadly, I am not a CI person, so cannot really help with that

Okay, it makes perfect sense, that sinks aren't built during CI checks, especially those linking with outside libs. But still - C++11 compilance should stand

@gabime gabime merged commit 3547d7e into gabime:v1.x Aug 2, 2021
@gabime
Copy link
Owner

gabime commented Aug 2, 2021

Thanks @jabartek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants